Ensure refs in tsconfig files are synced with internal deps by mcmire · Pull Request #8384 · MetaMask/core

mcmire · 2026-04-06T15:39:44Z

Explanation

Problem

We use project references to tell TypeScript and other tools about the structure of the monorepo. Both the root- and package-level tsconfig files have a references field which is used to link packages together. All packages that we want to build and publish need to be present in references within the root tsconfig.json and tsconfig.build.json files, and the references field in both root-level and package-level tsconfig files need to list all internal dependencies.

However, it's a pain to keep references up to date, especially as as packages are added or dependencies are updated. There are cases in the past, in fact, where packages were not published or type errors occurred because the references were not correctly kept in sync.

Solution

We don't need to do this manual work. We can infer root references by scanning workspaces, and we can infer references for an individual package by scanning that package's dependencies for other workspace packages.

This commit adds a script that can be run on both the root workspace and child workspaces to check and/or regenerate the references field for each tsconfig file so that it is kept in sync with dependencies throughout the monorepo. There are also new package scripts for use:

Root level
- lint:tsconfigs: Validates the root tsconfig.json and tsconfig.build.json, erroring if any are out of sync.
- lint:tsconfigs:all: Validates all tsconfig.json and tsconfig.build.json across the monorepo, erroring if any are out of sync.
- lint:tsconfigs:fix: Regenerates the root tsconfig.json and tsconfig.build.json.
- lint:tsconfigs:fix:all: Regenerates tsconfig.json and tsconfig.build.json files across the monorepo.
Package level
- lint:tsconfigs: Validates tsconfig.json and tsconfig.build.json in the package, erroring if any are out of sync.
- lint:tsconfigs:fix: Regenerates tsconfig.json and tsconfig.build.json in the package.

As the names indicate, tsconfig file validation is also a part of the lint pipeline, so CI will now fail if any files are out of date. To make sure this doesn't happen in the future, this commit also corrects tsconfig files across the board to add missing references or remove extra references.

Why hand-roll a solution?

There are some existing solutions for syncing references within the TypeScript community, some of which are documented in this issue. However, I reviewed them and rejected them for various reasons:

typescript-monorepo-toolkit: Doesn't update references for individual packages based on dependencies
update-ts-references: Works, but re-sorts all references, and drops the leading ./ from references in root tsconfig files; also, generated files fail Prettier validation
@monorepo-utils/workspaces-to-typescript-project-references: Works, but re-sorts all references, and drops the leading ./ from references in root tsconfig files; also generated files fail Prettier validation

My thought is that by building our own script, we get to control the exact changes that are made to tsconfig files, and we get to run all files through Oxfmt so that engineers do not have to reformat them manually.

References

Closes #966.

Also closes https://consensyssoftware.atlassian.net/browse/WPC-649.

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Wide monorepo tsconfig and declared-dependency changes can affect composite builds; a few packages gain runtime deps to match messenger/types usage.

Overview
Adds lint-tsconfigs (scripts/lint-tsconfigs/lint-tsconfigs.mts) to validate or regenerate references in root and package tsconfig.json / tsconfig.build.json from workspace layout and each package’s internal dependencies. Root lint and CI now run lint:tsconfigs:all; every package gets lint:tsconfigs / lint:tsconfigs:fix scripts.

This PR realigns references repo-wide (adds missing project refs, drops extras, normalizes path formatting) and fixes a few dependency/tsconfig mismatches the linter surfaced: e.g. @metamask/preferences-controller on eip-5792-middleware, @metamask/controller-utils on keyring-controller, and README dependency edges. ESLint now covers scripts/**/*.{ts,mts} and .mts for TypeScript rules.

Small follow-on code tweaks: stricter typing in permission-middleware, removal of a PerpsController @ts-expect-error after reference fixes.

^{Reviewed by Cursor Bugbot for commit 2886d3b. Bugbot is set up for automated code reviews on this repo. Configure here.}

mcmire · 2026-04-06T15:43:31Z

+      "path": "../messenger/tsconfig.build.json"
+    },
+    {
+      "path": "../controller-utils/tsconfig.build.json"


This dependency is present in devDependencies but was missing as a reference.

mcmire · 2026-04-06T15:43:34Z

+      "path": "../messenger"
+    },
+    {
+      "path": "../controller-utils"


This dependency is present in devDependencies but was missing as a reference.

mcmire · 2026-04-06T15:45:27Z

+      "path": "../phishing-controller/tsconfig.build.json"
+    },
+    {
+      "path": "../multichain-account-service/tsconfig.build.json"


These dependencies are present in dependencies but were missing as references.

mcmire · 2026-04-06T15:45:36Z

+      "path": "../transaction-controller"
+    },
+    {
+      "path": "../multichain-account-service"


These dependencies are present in dependencies but were missing as references.

mcmire · 2026-04-06T15:46:35Z

  "references": [
    {
-      "path": "../controller-utils/tsconfig.build.json"
+      "path": "../messenger/tsconfig.build.json"


base-controller no longer depends on controller-utils. It now lists json-rpc-engine as a dev dependency.

mcmire · 2026-04-06T16:08:43Z

      "path": "../transaction-controller/tsconfig.build.json"
+    },
+    {
+      "path": "../messenger/tsconfig.build.json"


New dependency.

mcmire · 2026-04-06T16:09:02Z

      "path": "../messenger/tsconfig.build.json"
+    },
+    {
+      "path": "../approval-controller/tsconfig.build.json"


New dependency.

mcmire · 2026-04-06T16:09:06Z

+      "path": "../approval-controller/tsconfig.build.json"
+    },
+    {
+      "path": "../eth-block-tracker/tsconfig.build.json"


New dev dependency.

mcmire · 2026-04-06T16:18:02Z

      "path": "./packages/user-operation-controller"
+    },
+    {
+      "path": "./packages/eip-5792-middleware"


Not sure how these were never added to the root tsconfig 🤔

IIRC ts-bridge resolves these either way if they are specified as references in other packages. Makes sense to add them here though.

socket-security · 2026-04-06T17:52:12Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

mcmire · 2026-04-06T17:57:02Z

      "path": "../json-rpc-engine"
    },
-    {
-      "path": "../network-controller"


No longer a dependency.

mcmire · 2026-04-06T17:59:27Z

@SocketSecurity ignore npm/@metamask/preferences-controller@23.1.0

This is our package.

mcmire · 2026-04-06T18:00:49Z

Adding no-changelog here because none of the changes to tsconfigs need to be logged.

mcmire · 2026-04-06T20:22:27Z

Curious if our team should be co-codeowners of tsconfig.json and tsconfig.build.json files 🤔 This would make this PR merge a lot faster.

cryptodev-2s · 2026-04-07T11:57:26Z

Curious if our team should be co-codeowners of tsconfig.json and tsconfig.build.json files 🤔 This would make this PR merge a lot faster.

I do believe we should

We use project references to tell TypeScript and other tools about the structure of the monorepo. Both the root- and package-level tsconfig files have a `references` field which is used to link packages together. All packages that we want to build and publish need to be present in `references` within the root `tsconfig.json` and `tsconfig.build.json` files, and the `references` field in both root-level and package-level tsconfig files need to list all internal dependencies. However, manually keeping all of these references up to date as packages are added or dependencies are updated is a pain. There are cases where packages were not published or type errors occurred because the references were not correctly kept in sync. We don't need to do this manual work. We can infer root references by scanning workspaces, and we can infer references for an individual package by scanning that package's `dependencies` for other workspace packages. This commit adds a script that can be run on both the root workspace and child workspaces to check and/or regenerate the `references` field for each tsconfig file so that it is perfectly kept in sync with dependencies throughout the monorepo. There are also some package scripts for use: - Root level - **`lint:tsconfigs`:** Validates the root `tsconfig.json` and `tsconfig.build.json`, erroring if any are out of sync. - **`lint:tsconfigs:all`:** Validates all `tsconfig.json` and `tsconfig.build.json` across the monorepo, erroring if any are out of sync. - **`lint:tsconfigs:fix`:** Regenerates the root `tsconfig.json` and `tsconfig.build.json`. - **`lint:tsconfigs:fix:all`:** Regenerates `tsconfig.json` and `tsconfig.build.json` files across the monorepo. - Package level - **`lint:tsconfigs`:** Validates `tsconfig.json` and `tsconfig.build.json` in the package, erroring if any are out of sync. - **`lint:tsconfigs:fix`:** Regenerates `tsconfig.json` and `tsconfig.build.json` in the package. As the names indicate, tsconfig file validation is also a part of the lint pipeline, so CI will now fail if any files are out of date. Finally, it's worth noting that there are some existing solutions in the TypeScript community, some of which are documented in [this issue][1], but all of which were rejected for various reasons: - **[`typescript-monorepo-toolkit`][2]:** Doesn't update references for individual packages based on `dependencies` - **[`update-ts-references`][3]:** Works, but re-sorts all references, and drops the leading `./` from references in root tsconfig files; also, generated files fail Prettier validation - **[`@monorepo-utils/workspaces-to-typescript-project-references`][4]:** Works, but re-sorts all references, and drops the leading `./` from references in root tsconfig files; also generated files fail Prettier validation Essentially, by building our own script, we get to control the exact changes that are made to tsconfig files, and we get to run all files through Prettier so that engineers do not have to reformat them manually. [1]: microsoft/TypeScript#25376 [2]: https://github.com/Bnaya/typescript-monorepo-toolkit [3]: https://github.com/eBayClassifiedsGroup/update-ts-references [4]: https://github.com/azu/monorepo-utils/tree/master/packages/@monorepo-utils/workspaces-to-typescript-project-references

mcmire · 2026-07-10T20:35:58Z

Okay, I will put this PR on hold until I update the codeowners.

@cryptodev-2s Update: I think once we're happy with this PR, we can just force-merge it instead of updating codeowners. We don't update tsconfig.json often enough to warrant a change in codeowners. Plus I don't want to add more maintenance burden to the codeowners file as it's quite high right now.

mcmire · 2026-07-10T20:40:03Z

This is now ready for review again!

Mrtenz · 2026-07-13T10:13:16Z

+    workspaces,
+  });
+  const sortedExpectedWorkspaces = [...expectedPackageNames]
+    .sort((a, b) => a.localeCompare(b))


Does our target allow toSorted?

Suggested change

.sort((a, b) => a.localeCompare(b))

.toSorted((a, b) => a.localeCompare(b))

Good callout. These are scripts, so it really depends on the Node version. It looks like toSorted was added in ES2023, which is supported at least in the latest version of Node 20.x: https://node.green/#ES2023. So I think we should be good to use toSorted here.

Actually... this would require changing our lib setting (we use ES2020 right now). We could change it to ES2023 across the board, but I tried this and even though our target is still ES2020 it doesn't seem that toSorted gets compiled down to sort. Plus as Cursor points out, technically we still support Node 18 in node.engines. So... maybe this is not a good idea. I've reverted these changes in 16d5dc1.

Mrtenz · 2026-07-13T10:14:37Z

+ * Packages whose tsconfig files are intentionally excluded from linting and
+ * fixing, e.g. because their references are managed by hand.
+ */
+const EXCLUDED_PACKAGE_NAMES = new Set(['@metamask/snap-account-service']);


Why do we exclude this one?

It appears that @metamask/snap-account-service and @metamask/account-tree-controller have a circular dependency on each other. The Accounts team fixed this problem by copying types from account-tree-controller and leaving @metamask/account-tree-controller out from tsconfig.json / tsconfig.build.json: https://github.com/MetaMask/core/blob/60bb56c7726937935c94744d9b478adb8d9cbfc3/packages/snap-account-service/tsconfig.json.

Curiously, snap-account-service's package.json still includes account-tree-controller in the list of dependencies. I don't think this is necessary. I have reached out to the Accounts team to see if I can remove this. If we can do this then we don't this exception.

I've fixed snap-account-service and have dropped the exclusion of this package from this PR: 13fb9ef

Mrtenz · 2026-07-13T10:17:10Z

+ * Produces an updated `references` list within a tsconfig file that preserves
+ * the order of existing references, removes extras, and adds missing ones in
+ * the order they appear in `newReferences`.


Do we need to preserve order of existing references? I think it would be cleaner if we just alphabetically sort everything.

I thought about that, but we haven't been enforcing sorting, so every single package's tsconfig files would likely have to be updated. I figured it would be more difficult to understand the diffs in this PR if I did this. I can turn this on in this PR, but what do you think if I did it in another PR?

Doing it in a separate PR makes sense to me.

Mrtenz · 2026-07-13T10:19:06Z

      ["internal", "parent", "sibling", "index", "unknown"]
    ]
  },
+  "sortPackageJson": {


We should probably just enable this (in a separate PR). We did it previously with Prettier, not sure why we didn't enable this for Oxfmt.

Mrtenz · 2026-07-13T10:20:13Z

      "path": "./packages/user-operation-controller"
+    },
+    {
+      "path": "./packages/eip-5792-middleware"


IIRC ts-bridge resolves these either way if they are specified as references in other packages. Makes sense to add them here though.

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

…Mask#9493) ## Explanation  In a future commit, we want to automatically synchronize the `references` field in each package's tsconfig files with its dependencies. Currently, we would have to make an exception for `snap-account-service`, as it lists `account-tree-controller` as a dependency but purposefully excludes it from its tsconfig files to avoid a circular reference. However, this manual bookkeeping is unnecessary, as `snap-account-service` already works around the circular dependency by copying types from `account-tree-controller` instead of importing them. So the dependency is unnecessary and we can drop it from `snap-account-service`'s `package.json`. ## References  Unblocks MetaMask#8384. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them  --- > [!NOTE] > **Low Risk** > Dependency and documentation-only change; no runtime or API code changes, with types already duplicated locally. > > **Overview** > Removes **`@metamask/account-tree-controller`** from `@metamask/snap-account-service`’s declared dependencies and updates the monorepo dependency graph (`README.md`, `yarn.lock`). The package already avoids importing that controller and uses **locally mirrored types** in `src/types.ts` to break the `account-tree-controller` ↔ `multichain-account-service` ↔ `snap-account-service` cycle. > > The long **tsconfig** comments that documented why `account-tree-controller` was omitted from project references are deleted now that the npm dependency no longer exists—references stay limited to `keyring-controller` and `messenger`. This aligns `package.json` with actual build/runtime usage so future automation can sync tsconfig `references` from dependencies without a special-case exception. > > Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b7c3e84. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).

## Explanation  Oxfmt has the ability to alphabetically sort scripts defined in `package.json` files across the monorepo. This commit enables this feature and corrects lint violations. ## References  Extracted from MetaMask#8384. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them  --- > [!NOTE] > **Low Risk** > Tooling and JSON key ordering only; no application logic or script command changes. > > **Overview** > Enables **oxfmt** to alphabetically sort `scripts` in `package.json` files by adding `sortPackageJson.sortScripts: true` to `.oxfmtrc.json`. > > The diff applies that ordering to the root `package.json` and `packages/wallet-cli/package.json` (e.g. `create-release-branch`, `postinstall`, `skills`, and `test:prepare` move to their sorted positions). **Script commands are unchanged**—only key order. > > Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 0439165. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).

## Explanation `sentinel-api-service` was missing `lint:tsconfigs` and `lint:tsconfigs:fix` after MetaMask#8384 was merged. ## References  ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them  --- > [!NOTE] > **Low Risk** > Only `package.json` script entries change; no runtime or API behavior is affected. > > **Overview** > Adds **`lint:tsconfigs`** and **`lint:tsconfigs:fix`** to `@metamask/sentinel-api-service`’s `package.json`, using the same shared `../../scripts/lint-tsconfigs/lint-tsconfigs.mts` entry points as other packages. > > This brings the package in line with the monorepo convention introduced in MetaMask#8384 so tsconfig lint can run locally and in CI for this package too. > > Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 7ad22af. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).

## Explanation Update `bridge-status-controller` package from `74.2.0` to `74.3.0`.  ## References  ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them  --- > [!NOTE] > **Low Risk** > Version and changelog-only release with no code diff; consumers should note 74.3.0’s batch quote-status behavior when upgrading. > > **Overview** > **Monorepo release `1126.0.0`** bumps the root `@metamask/core-monorepo` version from `1125.0.0` and publishes **`@metamask/bridge-status-controller` `74.3.0`** (from `74.2.0`) with an updated package version and changelog. > > The new **`74.3.0`** changelog section documents behavior that ships with this release tag: **batch sell (EIP-7702 / nested batch)** support in the quote-status flow so every quote in one batch is reported to the backend as `SUBMITTED` under a shared source tx hash and `txMetaId`, with shared finalization on confirm/fail ([MetaMask#9514]). A **Changed** entry notes tsconfig project-reference sync with internal deps ([MetaMask#8384]). Compare links for `[Unreleased]` and `[74.3.0]` are updated accordingly. > > There are **no application source changes** in this diff—only `package.json` version fields and `CHANGELOG.md` release bookkeeping. > > Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 24b0fa0. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).

## Explanation  At the time of writing we have 97 (!!) packages in this monorepo, which are owned by various teams across MetaMask. However, managing codeownership via the CODEOWNERS file is tedious and error-prone. We do use Yarn constraints to ensure that each package is configured in CODEOWNERS correctly, so that helps. However, in a future commit, we would like to update the set of per-package files that are owned by Core Platform to include more than just `package.json` and `CHANGELOG`. at the moment, we need to do that manually — Yarn constraints won't allow us to automatically apply those updates — and it would be painful. To address this problem, this commit redefines `CODEOWNERS` as a TypeScript file (`codeowners.ts` in the root) and adds a script to generate CODEOWNERS from this file. The script also comes with a `check` command which is plugged into the lint pipeline to ensure that CODEOWNERS is always up to date. The primary "feature" of `codeowners.ts` is that it contains a configuration object which maps of teams to packages that are owned by those teams (along with some other metadata). Ideally, when a new package is added, all a team needs to do is update this map and then the appropriate codeowner rules will be automatically added to support that package. That said, to ensure minimal changes between the current version of CODEOWNERS and the new version in this PR, some compromises needed to be made, and as a result, `codeowners.ts` is not as dynamic or simple as it could be. In the future, we plan on making further changes to make `codeowners.ts` easier to maintain. ## References  To merge MetaMask#8384, I had to enable admin powers to bypass codeowner requirements. This is because tsconfig files are not co-owned by Core Platform. We could of course change CODEOWNERS to do this, but what if we want to add other kinds of files in the future? This file is already somewhat difficult to maintain and we don't want to make it worse. This PR came out of that observation. ## Manual testing - Run `yarn codeowners:check`. It should not print any output, and should exit with 0. - Run `yarn codeowners:generate`. It should also not print any output, it should not change `.github/CODEOWNERS`, and should exit with 0. - Open `codeowners.ts` and add `@MetaMask/core-platform` to the list of teams for `account-tree-controller`. - Run `yarn codeowners:check`. It should print an error. - Run `yarn codeowners:generate`. `.github/CODEOWNERS` should change (the list of owners for `account-tree-controller` should include @MetaMask/core-platform`). - Undo the changes to `.github/CODEOWNERS`. - Open `codeowners.ts` and remove `initializationPath` from `address-book-controller`. - Run `yarn codeowners:check`. It should print an error. - Run `yarn codeowners:generate`. `.github/CODEOWNERS` should change (`address-book-controller` should be removed from the "Initialization" section). ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them  --- > [!NOTE] > **Low Risk** > Repo tooling and generated ownership metadata only; no runtime product or security logic changes. > > **Overview** > **CODEOWNERS** is now generated from a root **`codeowners.ts`** config instead of being edited by hand. Teams update package ownership (and optional wallet **`initializationPath`** metadata) in one place; the generator builds team sections, joint ownership, initialization paths, and release **`package.json` / `CHANGELOG.md`** rules with aligned column padding. > > New **`yarn codeowners:generate`** and **`yarn codeowners:check`** (wired into **`lint`**, **`lint:fix`**, and the CI lint matrix) keep **`.github/CODEOWNERS`** in sync. **`tsconfig.json`** includes **`codeowners.ts`** for typechecking. > > Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 2426a9b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).

mcmire force-pushed the lint-tsconfig-files branch from 2929cc5 to 6cb4611 Compare April 6, 2026 15:41

mcmire commented Apr 6, 2026

View reviewed changes

mcmire added the no-changelog label Apr 6, 2026

mcmire commented Apr 6, 2026

View reviewed changes

Comment thread packages/eip-5792-middleware/package.json

mcmire marked this pull request as ready for review April 6, 2026 19:54

mcmire requested review from a team as code owners April 6, 2026 19:54

mcmire added 3 commits July 10, 2026 14:33

Fix types for createPermissionMiddleware

0aadda4

Sort package.json files

f581e73

mcmire force-pushed the lint-tsconfig-files branch from 1ef5070 to f581e73 Compare July 10, 2026 20:33

cursor Bot reviewed Jul 10, 2026

View reviewed changes

Comment thread scripts/lint-tsconfigs/utils.mts

Mrtenz requested changes Jul 13, 2026

View reviewed changes

Apply suggestions from code review

567a301

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

cursor Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread scripts/lint-tsconfigs/utils.mts Outdated

Undo .toSorted

16d5dc1

This was referenced Jul 13, 2026

Sort scripts in package.json files #9492

Merged

[snap-account-service] Remove extra account-tree-controller dep #9493

Merged

Merge branch 'main' into lint-tsconfig-files

ecd9a6e

mcmire added 2 commits July 14, 2026 07:24

Merge branch 'main' into lint-tsconfig-files

c2ef4bb

No need to exclude snap-account-service anymore

13fb9ef

Mrtenz previously approved these changes Jul 15, 2026

View reviewed changes

Merge branch 'main' into lint-tsconfig-files

2886d3b

mcmire dismissed Mrtenz’s stale review via 2886d3b July 15, 2026 13:38

Mrtenz approved these changes Jul 15, 2026

View reviewed changes

mcmire merged commit 58cd8e9 into main Jul 15, 2026
429 of 435 checks passed

mcmire deleted the lint-tsconfig-files branch July 15, 2026 14:03

Mrtenz mentioned this pull request Jul 15, 2026

chore: add missing scripts to sentinel-api-service #9522

Merged

4 tasks

cursor Bot mentioned this pull request Jul 15, 2026

Release/1126.0.0 #9528

Merged

4 tasks

mcmire mentioned this pull request Jul 15, 2026

Manage CODEOWNERS programmatically (and regenerate it) #9529

Merged

4 tasks

	.sort((a, b) => a.localeCompare(b))
	.toSorted((a, b) => a.localeCompare(b))

Uh oh!

Uh oh!

Conversation

mcmire commented Apr 6, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

Problem

Solution

Why hand-roll a solution?

References

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

socket-security Bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcmire Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcmire commented Apr 6, 2026

Uh oh!

mcmire commented Apr 6, 2026

Uh oh!

Uh oh!

mcmire commented Apr 6, 2026

Uh oh!

cryptodev-2s commented Apr 7, 2026

Uh oh!

Uh oh!

mcmire commented Jul 10, 2026

Uh oh!

mcmire commented Jul 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcmire Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcmire commented Apr 6, 2026 •

edited by cursor Bot

Loading

socket-security Bot commented Apr 6, 2026 •

edited

Loading

mcmire Apr 6, 2026 •

edited

Loading

mcmire Jul 13, 2026 •

edited

Loading